Implementing sampling stats#550
Merged
Merged
Conversation
willow-ahrens
marked this pull request as draft
July 3, 2026 21:35
Member
|
@Ruchika-2003 can we get this ready to go? |
Collaborator
Author
I removed the heuristic flag as we discussed, the current one with those changes is ready to go |
Member
|
@Ruchika-2003 fix precommit and resolve conflicts |
willow-ahrens
marked this pull request as ready for review
July 24, 2026 17:12
willow-ahrens
enabled auto-merge (squash)
July 24, 2026 17:13
willow-ahrens
approved these changes
Jul 24, 2026
willow-ahrens
left a comment
willow-ahrens
left a comment
Member
There was a problem hiding this comment.
@Ruchika-2003 I'm approving this now to keep everything in sync, but I do think we'll need to make some performance improvements later.
yusheng036
pushed a commit
that referenced
this pull request
Jul 24, 2026
* pulling main * implementing and testing sampling estimator * Changes made to sampling_stats and tests added * Removing poetry.lock * matching masks for same dimension * implemented estimators from the stats paper * updates sampling_stats without tensordef * use_coverage implemented in sampling_stats * heuristic flag removed * added good1 and silly sampling * resolving mypy errors * reolving errors --------- Co-authored-by: Willow Ahrens <willow@csail.mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.